-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outbox Improvements for Relation Database #3464
Outbox Improvements for Relation Database #3464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (8.65 -> 8.65)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (8.65 -> 8.65)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (8.70 -> 8.70)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good cleanup, appreciated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (8.70 -> 8.70)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 2 files(s) 🔥
Thanks @lillo42 |
PS: I changed how we get the (un)dispatched message before we use the database date time and I changed for the client side making the logic easier (before these changes some tests were failing randomly due to some mismatch between my local machine and my local container, I guess)