Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbox Improvements for Relation Database #3464

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

lillo42
Copy link
Contributor

@lillo42 lillo42 commented Jan 9, 2025

PS: I changed how we get the (un)dispatched message before we use the database date time and I changed for the client side making the logic easier (before these changes some tests were failing randomly due to some mismatch between my local machine and my local container, I guess)

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (8.65 -> 8.65)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (8.65 -> 8.65)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (8.70 -> 8.70)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

@iancooper
Copy link
Member

before we use the database date time
Good shout, and you are right that may fix some issues for us

Copy link
Member

@iancooper iancooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good cleanup, appreciated

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (8.70 -> 8.70)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 2 files(s) 🔥

View detailed results in CodeScene

@iancooper
Copy link
Member

Thanks @lillo42

@iancooper iancooper merged commit cff67fd into BrighterCommand:master Jan 15, 2025
14 of 20 checks passed
@lillo42 lillo42 deleted the outbox-rdb-improves branch January 15, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] MySQL Outbox - PagedDispatchedCommand fails
2 participants